Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Won't Do
-
1.7.0
-
None
Description
Depend on trohrmann@apache.org's commit, AbstractYarnClusterDescriptor should not care whether it is in DETACHED mode.
After digging I found the main usages of it are
1. FlinkYarnSessionCli#run, this can be resolved by checking whether allOptions has DETACHED_OPTION locally.
2. when AbstractYarnClusterDescriptor start a AM, it sets appMasterEnv.put(YarnConfigKeys.ENV_DETACHED, String.valueOf(detached));. At this point it seems that YarnClusterDescriptor should know whether or not it is in detached mode.
If usage 2 is irrelevant now, we can get rid of deprecated method in FLIP-6 codebase.
Attachments
Issue Links
- links to