[FLINK-10065] InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Labels: pull-request-available
• Assignee: Congxian Qiu
• Reporter: Congxian Qiu
• Created: 06/Aug/18 07:38
• Updated: 28/Sep/18 16:41
• Resolved: 28/Sep/18 16:41

Description

Now, the implementation of InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) is 

@SuppressWarnings("unchecked")
public static <T> T deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant)
throws IOException, ClassNotFoundException {
final ClassLoader old = Thread.currentThread().getContextClassLoader();
// not using resource try to avoid AutoClosable's close() on the given stream
try (ObjectInputStream oois = isFailureTolerant
? new InstantiationUtil.FailureTolerantObjectInputStream(in, cl)
: new InstantiationUtil.ClassLoaderObjectInputStream(in, cl)) {
Thread.currentThread().setContextClassLoader(cl);
return (T) oois.readObject();
}
finally {
Thread.currentThread().setContextClassLoader(old);
}
}

InputStream is closable, so the parameter will be closed after call this method.

Issue Links

• links to: GitHub Pull Request #6498