[FLEX-34853] ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Apache Flex 4.14.1
• Fix Version/s: Apache Flex 4.15.0
• Component/s: Collections, Spark: Sort and SortField
• Assignee: Mihai Chira
• Reporter: Mihai Chira
• Created: 22/May/15 14:00
• Updated: 09/Nov/16 13:42

Description

            _sut.addAll(from4To0); //values["name"]: Object4, Object3, Object2, Object1, Object0

            const sortByIndexAscending:Sort = new Sort();
            sortByIndexAscending.fields = [new SortField("index", false, false, true)];
            _sut.sort = sortByIndexAscending;
            _sut.refresh(); //should be: Object0, Object1, Object2, Object3, Object4

            //when
            sortByIndexAscending.fields = [new SortField("name", false, true, false)]; //should have no effect

            //then
            assertThat(_sut.getItemIndex(from4To0.getItemAt(i)) != -1); //an RTE is thrown here

Expected behaviour: the collection should resort when any of the flags of its Sort object changes, or whenever one of the flags of the Sort's SortField list changes. That, or Sort and SortField should be made immutable, to prevent this scenario in the first place.

Sub-Tasks

• Sort and SortField state setters are now behind mx_internal and out of the interfaces: Open
• Refactor Sort.reverse() and SortField.reverse() to work with immutable Sort and SortField objects: Open
• Make Sort and SortField immutable by removing any state setters: Open