[FLEX-34229] DataGridEditor doesn't remove the Event.DEACTIVATE listener on destroyItemEditor()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Apache Flex 4.12.0
• Fix Version/s: Apache Flex 4.12.1
• Component/s: Spark: DataGrid
• Assignee: Alex Harui
• Reporter: Mihai Chira
• Created: 16/Apr/14 10:19
• Updated: 18/Apr/14 21:14
• Resolved: 18/Apr/14 21:14

Description

Steps to reproduce:
1. Import and run attached project.
2. Set a breakpoint in DataGridEditor.deactivateHandler().
3. Double click on 'hello' to show the editor.
4. Click in the grid under 'hello' to remove the editor.
5. Click on the Remove Grid button.
6. Click anywhere outside the AIR app to de-focus it.

Actual result: the breakpoint is triggered, which means that the DataGridEditor is still responding to Event.DEACTIVATE even after the editor was closed, and even after the grid was removed.
Desired result: DataGridEditor.deactivateHandler() should only be called while an editor is open, as long as the grid itself is still on stage (NB the grid can be removed while the editor is still open, see FLEX-34216 for the problems that causes).

Expected result: the breakpoint is not triggered.

Notes:
-the second line of DataGridEditor.destroyItemEditor() looks like a typo: instead of addEventListener shouldn't it say removeEventListener(...)?