Uploaded image for project: 'Apache Flex'
  1. Apache Flex
  2. FLEX-33893

CSSStyleDeclaration is inefficient during style matching

    XMLWordPrintableJSON

Details

    Description

      When no factory (or defaultFactory) is provided a new function is created when matching styles (addFactoryAndOverrideStylesToProtoChain, addStyleToProtoChain, applyFilter).
      This is a major source of unneeded memory allocations (== GC)

      The patch re-use a single function as the prototype is always reseted
      This should be reviewed by an actionscript ninja

      Attachments

        1. 0001-cssstyledeclaration-optimization.patch
          3 kB
          Benoit Wiart
        2. cssstyledeclaration-example-1-mobile.png
          117 kB
          Benoit Wiart
        3. cssstyledeclaration-example-2-mobile.png
          63 kB
          Benoit Wiart
        4. protochain-before-after.png
          163 kB
          Benoit Wiart

        Activity

          People

            jmclean Justin Mclean
            benoitw Benoit Wiart
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: