Uploaded image for project: 'Apache Flex'
  1. Apache Flex
  2. FLEX-28469

Accordion.selectedElement should be typed as AccordionContent, not IVisualElement

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Not A Problem
    • Adobe Flex SDK Next
    • None
    • Spark: Accordion
    • None
    • Affected OS(s): All OS Platforms
      Affected OS(s): All OS Platforms
      Language Found: English

    Description

      Steps to reproduce:
      1. Look at Accordion.selectedElement getter

      Actual Results:
      It's a IVisualElement

      Expected Results:
      It should be AccordionContent

      Workaround (if any):
      Cast it

      An underlying assumption in Accordion is that its elements are always AccordionContents. IVisualElement is unnecessarily generic. Perhaps the method name should also be changed to selectedAccordionContent or selectedContent for clarity. The selectedElement name appears to be taken from ViewStack, but ViewStack is much more generic.

      This change will require refactoring method names and removing AccordionContent casts throughout all of the Accordion files.

      Attachments

        Activity

          People

            adobejira Adobe JIRA
            adobejira Adobe JIRA
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: