[FLEX-28355] DateSpinner.minuteStepSize short circuits too soon

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Adobe Flex SDK Previous
• Fix Version/s: Adobe Flex SDK Previous
• Component/s: Mobile: DateSpinner
• Environment: Affected OS(s): All OS Platforms; Affected OS(s): All OS Platforms; Language Found: English
• Assignee: Adobe JIRA
• Reporter: Adobe JIRA
• Created: 26/Aug/11 14:39
• Updated: 04/Sep/11 20:24
• Resolved: 29/Aug/11 11:33

Description

Steps to reproduce:
1. Look at the source code for DateSpinner.minuteStepSize setter
2.
3.

Actual Results:

The short circuit is first

public function set minuteStepSize(value:int):void

{ if (value == _minuteStepSize) return; if (value <= 0 || 60 % value != 0) value = 1; _minuteStepSize = value; minuteStepSizeChanged = true; populateMinuteDataProvider = true; invalidateProperties(); }

Expected Results:

The short circuit should be after the invalid value adjustment

public function set minuteStepSize(value:int):void

{ if (value <= 0 || 60 % value != 0) value = 1; if (value == _minuteStepSize) return; _minuteStepSize = value; minuteStepSizeChanged = true; populateMinuteDataProvider = true; invalidateProperties(); }

Workaround (if any):