[FINERACT-821] Enable and enforce (!) Checkstyle in Fineract

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Assignee: Manthan Surkar
• Reporter: Michael Vorburger
• Created: 10/Jan/20 16:49
• Updated: 26/Oct/20 08:23
• Resolved: 26/Aug/20 01:15

Description

as suggested in FINERACT-712, we really should enable Checkstyle in Fineract.

My past experience in such matters, confirmed by FINERACT-702, is that these things only ever work and have a lasting effect if you bulk fix all violations and switch on enforcement. If you only report, it's mostly useless.

As for specific Checkstyle rules, I have spent a fair amount of time in a past life on a project (which I'm currently no longer actively invoved in) to refine a what I believe to be "good" Checkstyle rule set, we could reuse this for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml

Issue Links

• blocks: FINERACT-971 Activate a few additional recently introduced new Checkstyle rules
• blocks: FINERACT-712 Fineract codebase should pass PMD, Findbugs and Checkstyle analysis
• incorporates: FINERACT-942 Make Checkstyle detect bad logging anti-patterns (and fix problems found)
• relates to: FINERACT-1006 Auto Format Source Code
• links to: GitHub Pull Request #688
• links to: GitHub Pull Request #689
• links to: GitHub Pull Request #704
• links to: GitHub Pull Request #883
• links to: GitHub Pull Request #920
• links to: GitHub Pull Request #922
• links to: GitHub Pull Request #923
• links to: GitHub Pull Request #931
• links to: GitHub Pull Request #933
• links to: GitHub Pull Request #934
• links to: GitHub Pull Request #935
• links to: GitHub Pull Request #936
• links to: GitHub Pull Request #937
• links to: GitHub Pull Request #938
• links to: GitHub Pull Request #963
• links to: GitHub Pull Request #978
• links to: GitHub Pull Request #984
• links to: GitHub Pull Request #985
• links to: GitHub Pull Request #986
• links to: GitHub Pull Request #990
• links to: GitHub Pull Request #991
• links to: GitHub Pull Request #1010
• links to: GitHub Pull Request #1019
• links to: GitHub Pull Request #1038
• links to: GitHub Pull Request #1039
• links to: GitHub Pull Request #1041
• links to: GitHub Pull Request #1042
• links to: GitHub Pull Request #1058
• links to: GitHub Pull Request #1059
• links to: GitHub Pull Request #1060
• links to: GitHub Pull Request #1061
• links to: GitHub Pull Request #1062
• links to: GitHub Pull Request #1063
• links to: GitHub Pull Request #1064
• links to: GitHub Pull Request #1065
• links to: GitHub Pull Request #1066
• links to: GitHub Pull Request #1067
• links to: GitHub Pull Request #1072
• links to: GitHub Pull Request #1073
• links to: GitHub Pull Request #1080
• links to: GitHub Pull Request #1081
• links to: GitHub Pull Request #1082
• links to: GitHub Pull Request #1088
• links to: GitHub Pull Request #1149
• links to: GitHub Pull Request #1150
• links to: GitHub Pull Request #1173
• links to: GitHub Pull Request #1240
• links to: GitHub Pull Request #1242
• links to: GitHub Pull Request #1290