[FINERACT-747] Performance updates : change String.replaceAll() to replace() if the replaced one is plain string.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Labels: pull-request-available
• Assignee: bd2019us
• Reporter: bd2019us
• Created: 14/Apr/19 00:51
• Updated: 08/May/20 23:06
• Resolved: 18/Apr/19 17:57

Description

Locations: 

(1) fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleJsonInputParams.java
(2) fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/fixeddeposits/

FixedDepositTransactionWorkbookPopulator.java
(3) fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/loanrepayment/LoanRepaymentWorkbookPopulator.java
(4) fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/savings/SavingsTransactionsWorkbookPopulator.java
(5) fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java
(6) fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/CenterReadPlatformServiceImpl.java
(7) fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupReadPlatformServiceImpl.java
(8) fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java

 

The String.replaceAll(regex, other) is usually used to replace strings represented by regular expression "regex". When the replaced string is a plain string but regex form, the String.replace(origin, other) is recommended as it does not need to compile and can improve the performance.

Issue Links

• links to: GitHub Pull Request #558