[FILEUPLOAD-189] DiskFileItemFactory use of FileCleaningTracker is documented or coded wrong

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2.2
• Fix Version/s: 1.3
• Assignee: Simone Tripodi
• Reporter: Gregor K
• Created: 07/Apr/11 08:04
• Updated: 06/Jun/17 04:49
• Resolved: 06/Mar/13 19:44

Description

Regarding latest SVN revision:

The DiskFileItemFactory documents:
Temporary files are automatically deleted as soon as they are no longer needed. (More precisely, when the corresponding instance of

{@link java.io.File}

is garbage collected.)

But the code in DiskFileItemFactory.createItem() is doing:
tracker.track(result.getTempFile(), this);

Which means the file is cleaned when DiskFileItemFactory is garbage collected.

This error is propably introduced in Rev 578253 when the code was moved from DiskFileItem to DiskFileItemFactory, without changing "this" (which was DiskFileItem) and is not DiskFileItemFactory.

Issue Links

• relates to: SOLR-1953 It may be possible for temporary files to accumulator until the Solr process is shut down