Uploaded image for project: 'Commons FileUpload'
  1. Commons FileUpload
  2. FILEUPLOAD-16

[fileupload][PATCH] Workaround for IE5 Mac type=image bug

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Bugzilla Id:
      30061

      Description

      Gentlehackers,

      Much to our dismay, and we're sure shortly to yours, we have
      found a bug in IE 5 for Mac where it is (shockingly) not
      conformant to the multipart/form-data specification.
      Our first reaction was whether we could just forget about IE5
      for the Mac, but we are told it is the best browser for Mac
      OS 9, which is still dear to the hearts of our target audience.
      Our second reaction .... well let's suffice it to say we cooked
      up several plans and it seemed like working around the bug in the
      File Upload code could actually be done simply without harming
      anything else.

      The bug is that the carriage return is missing on any boundary
      line immediately preceding an input with type=image.
      (type=submit does not have the bug.)

      Because the boundary delimiter, not including the trailing
      CRLF, must not appear within any file (RFC 2046, section
      5.1.1), we know the missing CR is due to a buggy browser
      rather than a file containing something similar to a
      boundary.

      This case had previously always been throwing an exception, so
      our patch does not interfere with any previously-working
      situation.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              justin@armory.com Justin Sampson

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment