[FILEUPLOAD-141] Remove FileItems if FileUploadBase.parseRequest() fails

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.2
• Fix Version/s: 1.2.2

Environment

commons-fileupload is used for parsing multipart/form-data POST requests in servlets.
OS: Linux

• Assignee: Unassigned
• Reporter: Marcus Klein
• Created: 23/Jul/07 10:54
• Updated: 05/Jun/17 14:09
• Resolved: 10/Mar/13 11:57

Description

If the method FileUploadBase.parseRequest() throws a FileUploadException, the already parsed FileItem objects are not accessible and removed by the garbage collector. Now expect a fileupload that fills the servers hard disc with FileItems until no space is left on the device. The method parseRequest() throws a FileUploadException and there are several FileItem objects that still exist in the device because the garbage collector does not run and removes them. This causes failing fileuploads until the garbage collector runs and removes the lost FileItem objects. I suggest calling FileItem.delete() on all FileItem objects created in the method FileUploadBase.parseRequest() if the method is left with a FileUploadException.

Issue Links

• duplicates: FILEUPLOAD-160 disk leak if multipart parse error