[FELIX-6493] Extend is-up-to-date logic of Manifest goal

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: maven-bundle-plugin-5.1.3
• Fix Version/s: maven-bundle-plugin-5.1.5
• Component/s: Maven Bundle Plugin
• Assignee: Jean-Baptiste Onofré
• Reporter: Hannes Wellmann
• Created: 30/Dec/21 10:25
• Updated: 15/Jul/22 07:49
• Resolved: 22/Apr/22 05:51

Description

The ManifestPlugin has a logic to determine if the manifest is already up-to-date in incremental builds (mainly introduced with FELIX-4009 and FELIX-6074).

This is-up-to-date logic should be extended to consider the following cases:

• The MANIFEST.MF file to generate does not exist
• the pom.xml has changed since the last complete-execution.
  Besides the instructions, other elements of the pom.xml can influence the generated manifest like dependencies or properties that are used in the instructions.

Furthermore the incremental-infos file should be written after the generated MANIFEST.MF was written, because isUpToDate(MavenProject) checks the target/classes folder where the generated MANIFEST.MF is written to (by default). If the incremental-infos are written first, it is likely that the generated MANIFEST.MF is not written in the same millisecond, so in the next call of isUpToDate(MavenProject) the generated MANIFEST.MF will be detected as modified causing a false-negative is-up-to-date check.

 

These problem where observed in the context of work on Eclipse-M2E to improve the integration of Maven-Projects that use the maven-bundle-plugin into the Eclipse-PDE workspace build. If you are interested, these are associated Issues/PRs:

• https://github.com/eclipse-m2e/m2e-core/issues/439
• https://github.com/eclipse-m2e/m2e-core/pull/440

 

Issue Links

• breaks: FELIX-6526 The "manifest" goal does not work anymore in modules which are using aspectj-maven-plugin "compile" goal
• breaks: FELIX-6548 NPE in org.apache.felix:maven-bundle-plugin:5.1.7:manifest when called without clean
• breaks: FELIX-6527 Maven Felix plugin broken when supportIncrementalBuild is false
• links to: GitHub Pull Request #124