[FELIX-6044] Component deactivation does not cause reference services to be ungotten

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: scr-2.1.14
• Fix Version/s: scr-2.1.16
• Component/s: Declarative Services (SCR)
• Assignee: Tom Watson
• Reporter: Tom Watson
• Created: 01/Feb/19 17:21
• Updated: 01/Mar/19 14:26
• Resolved: 05/Feb/19 16:39

Description

The fix to FELIX-5974 has caused an issue for the default reference scope of bundle. When a component has a simple @Reference and that component is deactivated the services that it references will not be ungotten by SCR. This causes all kinds of issues for use counting of the consumed service.

The issue is that org.apache.felix.scr.impl.manager.DependencyManager.close(ComponentContextImpl<S>, EdgeInfo) is calling RefPair.unsetServiceObject now for all RefPair types. The RefPair types MultiplePrototypeRefPair and SinglePrototypeRefPair were updated to have unsetServiceObject to also have that service be ungotten. But the default SingleRefPair type was not. This causes issues when ultimately the DependencyManagers are deactivated later which then closes the customizer for the dependency and org.apache.felix.scr.impl.manager.DependencyManager.AbstractCustomizer.ungetService(RefPair<S, T>) is called. By this time there will now be a null service and it will not be ungotten.

Issue Links

• links to: GitHub Pull Request #180