[FELIX-6026] SCR command problems

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: scr-2.1.14
• Fix Version/s: scr-2.1.16
• Component/s: Declarative Services (SCR)
• Assignee: Unassigned
• Reporter: Brent Daniel
• Created: 11/Jan/19 15:25
• Updated: 01/Mar/19 14:26
• Resolved: 25/Jan/19 22:28

Description

There are a couple of problems resulting from the changes to SCR commands in https://github.com/apache/felix/pull/130 .

First, ScrInfo is not registered as a service when ds.info.service=true is specified in config admin. The core issue is that the setScrCommand method of ScrConfigurationImpl is never called, so it will not be available in this block around line 208:

if ( scrCommand != null )
{
scrCommand.updateProvideScrInfoService( infoAsService() );
}

That can be fixed by adding the following to the Activator.doStart() method (though I haven't spent much time thinking about better solutions):

m_configuration.setScrCommand(m_componentCommands);

Second, the ScrInfo list() and info() implementation no longer accept a null component ID. The javadoc for ScrInfo still indicates that a null ID will give information for all components. We have found this function invaluable for dumping the state of every component, so it would be nice to get this back.

 

Issue Links

• links to: GitHub Pull Request #172