Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-6016

Clean up util package in Health Check API

    XMLWordPrintableJSON

    Details

      Description

      Currently the bundle "org.apache.felix.healthcheck.api" contains the package "org.apache.felix.hc.util" with three classes. Utility packages are always a bit of a code smell, and in this case it can be avoided by 

      • Moving the class FormattingResultLog to package org.apache.felix.hc.api 
        • This is commonly used, but when migrating from Sling HCs the package names change anyway and "Organise Imports" in IDE fixes it quickly
      • Moving the class HealthCheckMetadata to package org.apache.felix.hc.api.execution 
        • It belongs to this package (it's only used there and in the impl). Most users don't require this (as the standard execution mechanisms suffice) - hence the change is not problematic
      • Moving the internal class HealthCheckFilter to bundle org.apache.felix.healthcheck.core
        • Since the introduction of the health check executor there was not much point of using this anymore, it's pretty much only used by executor implementation right now

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              henzlerg Georg Henzler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: