[FELIX-5950] NPE in MultiplePrototypeRefPair.unsetServiceObject

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: scr-2.1.14
• Component/s: Declarative Services (SCR)
• Environment: Mac OS X 10.14
• Assignee: Carsten Ziegeler
• Reporter: Olivier Prouvost
• Created: 04/Oct/18 09:10
• Updated: 13/Nov/18 11:04
• Resolved: 18/Oct/18 05:29

Description

I use Felix with the eclipse runtime (Photon 0918), and I get a NPE when running my application. 

 

Actually in the code of 

MultiplePrototypeRefPair.unsetServiceObject we have :  instances.get(key). 

If we search for the callers, the DependencyManager class call It like this : 

 

       protected void ungetService(RefPair<S, T> ref)

        {

            Object service = ref.unsetServiceObject(null);

            if (service != null)

 

Unfortunately, the instances map is a ConcurentHashMap which can not deal with null keys (it calls key.hashcode at the beginning), and this call will always raise an exception... 

Don't know what is the Felix version involved, but the bundle I use in my launch configuration is  (org.apache.felix.scr 2.0.14.v20180117)