[FELIX-586] org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): implementation does not properly handle Configuration instances of a ManagedServiceFactory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: webconsole-1.2.0
• Component/s: Web Console
• Assignee: Felix Meschberger
• Reporter: Dieter Wimberger
• Created: 01/Jun/08 05:25
• Updated: 02/May/13 02:29
• Resolved: 06/Aug/08 16:40

Description

The implementation of org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): does not properly handle Configuration instances of a ManagedServiceFactory.

In fact, if such a Configuration instance is passed in as a parameter, the method will throw an exception, because there is no ObjectClassDefinition available for the instance.

Example:
A Configuration instance for the ManagedServiceFactory "net.wimpi.telnetd.service.TelnetListenerServiceFactory" was created through the ConfigurationAdmin that assigned the pid "net.wimpi.telnetd.service.TelnetListenerServiceFactory-1212198114040-7". Given that the method will try to obtain an ObjectClassDefinition for "net.wimpi.telnetd.service.TelnetListenerServiceFactory-1212198114040-7", an exception will be thrown, because no such OCD is available.

Fix:
The method needs to check if the Configuration instance has a factoryPid assigned, and should use the factoryPid to obtain the ObjectClassDefinition corresponding to the ManagedServiceFactory.

Also observed in revision 662145 SVN repository.

Issue Links

• depends upon: FELIX-584 org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.applyConfiguration(): "create" action is not handled properly
• depends upon: FELIX-585 org.apache.felix.webconsole.internal.compendium.ConfigManager.listConfigurations(): Configuration instances for ManagedServiceFactoy instances cause IllegalArgumentException