[FELIX-584] org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.applyConfiguration(): "create" action is not handled properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: webconsole-1.2.0
• Component/s: Web Console
• Assignee: Felix Meschberger
• Reporter: Dieter Wimberger
• Created: 01/Jun/08 05:00
• Updated: 02/May/13 02:29
• Resolved: 06/Aug/08 16:37

Description

The current revision of the code (662145) creates the configuration, and returns true.

else if ( request.getParameter( "create" ) != null )

{ // pid is a factory PID and we have to create a new configuration // we should actually also display that one ! Configuration config = ca.createFactoryConfiguration( pid, null ); // request.setAttribute(ATTR_REDIRECT_PARAMETERS, "pid=" + // config.getPid()); return true; }

The problem with this approach is the fact that in many cases the Configuration instance will not be persisted or available until the update() method is used to set new properties.

Based on the fact that the "create" action may be called already with a complete set of properties edited in the form, I would suggest to only differentiate between factory "create" and "save" in the way the Configuration instance is created. i.e.:

if ( request.getParameter( "create" ) != null )
{
// pid is a factory PID and we have to create a new configuration
config = ca.createFactoryConfiguration( pid, null );
} else {
// pid is managed service, get configuration
config = ca.getConfiguration( pid, null );
}

Issue Links

• is depended upon by: FELIX-585 org.apache.felix.webconsole.internal.compendium.ConfigManager.listConfigurations(): Configuration instances for ManagedServiceFactoy instances cause IllegalArgumentException
• is depended upon by: FELIX-586 org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): implementation does not properly handle Configuration instances of a ManagedServiceFactory
• is depended upon by: FELIX-587 org.apache.felix.webconsole.internal.compendium.AjaxConfigManagerAction.configForm(): Configuration instance for a ManagedServiceFactory will cause Exception