[FELIX-5543] Component property types must implement java.lang.annotation.Annotation methods properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: scr-2.1.0
• Fix Version/s: scr-2.1.0
• Component/s: Declarative Services (SCR)
• Assignee: Carsten Ziegeler
• Reporter: Konrad Windszus
• Created: 14/Feb/17 10:09
• Updated: 30/Apr/18 08:13
• Resolved: 17/Mar/17 06:50

Description

Currently component property types only implement one getter method for each element. The methods toString(), equals(), hashCode() and annotationType are not implemented properly (i.e. all return just null). This violates JLS 9.6 (https://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.6).

The direct superinterface of an annotation type is always java.lang.annotation.Annotation.

The component property type needs to implement java.lang.annotation.Annotation and all its methods properly. The current implementation is clearly violating the contract of the java.lang.annotation.Annotation.
For that the Annotations#toObject(...) needs to be adjusted in https://github.com/apache/felix/blob/trunk/scr/src/main/java/org/apache/felix/scr/impl/inject/Annotations.java#L41.