[FELIX-5511] gogo runtime - Exception with a command named "?"

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: gogo.runtime-1.0.0
• Component/s: Gogo Runtime
• Assignee: Guillaume Nodet
• Reporter: Antoine DESSAIGNE
• Created: 27/Jan/17 13:57
• Updated: 18/Oct/17 12:24
• Resolved: 18/Oct/17 12:24

Description

Hello.

We currently use gogo runtime 0.16.2 and we have a command named "?" (fullname is "platform:?"), it's working fine.

I tried the update to version 1.0.0 and I have an exception when I try to use this command

java.io.IOException: no matches found: ?
	at org.apache.felix.gogo.runtime.Expander.generateFileNames(Expander.java:650)
	at org.apache.felix.gogo.runtime.Expander.expand(Expander.java:132)
	at org.apache.felix.gogo.runtime.Expander.expand(Expander.java:74)
	at org.apache.felix.gogo.runtime.Expander.expand(Expander.java:59)
	at org.apache.felix.gogo.runtime.Closure.eval(Closure.java:354)
	at org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:415)
	at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:367)
	at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:417)
	at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:229)
	at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

I can provide a pull request for it but I don't know how to fix it. One possible way is to not try to match file names when processing the first token. Would work in my case because it's the command but it may introduce lots of regression for other usages I'm not aware of.

Thank you very much for any help you can provide.