[FELIX-5432] Message when dependency is already added to a component is incomplete

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: org.apache.felix.dependencymanager-r8
• Component/s: Dependency Manager
• Assignee: Pierre De Rop
• Reporter: Jeroen Daanen
• Created: 30/Nov/16 14:17
• Updated: 04/Dec/16 23:17
• Resolved: 04/Dec/16 23:17

Description

If a dependency is added to a component, while the dependency has already been added to another component, the error message does not contain information to which component it was added already (while that information is available).

Probably it would be better to change the code in ComponentImpl.add(Dependency...)

if (dc.getComponentContext() != null) {
m_logger.err("%s can't be added to %s (dependency already added to component %s).", dc, ComponentImpl.this, dc.getComponentContext());
continue;
}