[FELIX-5315] Unexpected release of ConfigurationAdmin service in RegionConfigurationSupport

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: scr-2.0.4
• Fix Version/s: scr-2.0.6
• Component/s: Configuration Admin, Declarative Services (SCR)
• Assignee: David Jencks
• Reporter: James Watkins-Harvey
• Created: 01/Aug/16 15:45
• Updated: 06/Aug/16 07:09
• Resolved: 02/Aug/16 16:15

Description

In commit 978a710, RegionConfigurationSupport has been modified to obtain the ConfigurationAdmin service through the ConfigurationAdmin's bundle context (in getConfigAdmin(), around line 633). However, services acquired through that method are then released using the impersonated bundle's context (for example in the finally block of configureComponentHolder(ComponentHolder), around line 186, and the finally block of getConfigurationInfo(TargetedPID, TargetedPID, ComponentHolder, BundleContext), around line 465).

This cause leak of service on the ConfigurationAdmin's bundle context, as well as unexpected early release of services on impersonated bundle contexts, causing an IllegalStateException("Configuration Admin service has been unregistered") being thrown in ConfigurationAdminImpl#getConfigurationManager().