[FELIX-5111] Persistence Manager complete support for comments

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: fileinstall-3.5.0
• Component/s: File Install
• Assignee: Guillaume Nodet
• Reporter: munene kiruja
• Created: 20/Nov/15 19:03
• Updated: 08/Sep/17 08:18
• Resolved: 08/Sep/17 08:18

Description

Felix Fileinstall 3.5.0 added support for .config files with an elaborate format for type specification and also support for arrays (and collections).
However it did not support comments but would choke on them, combining comments with the configuration data and corrupting the configuration file. Also the .config files are sorted alphabetically, possibly altering the original order.

https://issues.apache.org/jira/browse/FELIX-4917 was created and a change submitted that was accepted, that allows the comments to be skipped over, but when the config is written back, the comments are lost. The sorting also still takes place.

Comments are a vital part of the user interface, communicating information about how to customize the OSGi services. To maintain equivalent functionality with the .cfg format, the following are necessary:

• reading the .config file should be able to skip the comments
• writing the .config file back should retain the comments and the structuer of the .config file
• updating should modify in the update map, leaving any in file but missing in the update set intact
• updating should add any values in update set but absent in the file

Issue Links

• is superceded by: FELIX-5609 Full support for both untyped and typed configurations