[FELIX-4819] Use Set instead of List for cycle detection

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: Resolver
• Labels: patch
• Assignee: Unassigned
• Reporter: Philippe Marschall
• Created: 02/Mar/15 19:13
• Updated: 05/Apr/15 12:38
• Resolved: 05/Apr/15 12:38

Description

We did some profiling of the Felix resolver in our application and 16% were spent in ArrayList#indexOf called by {{ArrayList#contains. It seems that ResolverImpl uses java.util.ArrayList for data structures on which it only calls #add and #contains with the latter being O. A java.util.HashSet is the appropriate data structure for such this use case.

Issue Links

• duplicates: FELIX-4656 Improve memory usage and speed of the resolver