[FELIX-4745] Support for aspectj advice static method

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: ipojo-manipulator-1.12.0, ipojo-manipulator-1.12.1
• Component/s: iPOJO
• Assignee: Clement Escoffier
• Reporter: Olivier NOUGUIER
• Created: 02/Jan/15 22:10
• Updated: 02/Feb/15 21:14

Description

When using aspectj to weave classes prior to iPojo packaging, injected advice are ignore by iPojo bytecode manipulation.
Then NPE are thrown in the advice because of the lazy initialization mechanism of @Requires services.

In my usecase, I want to weave @Transactional springframework aspect in iPojo component.

Code generated:

static final String updateName_aroundBody0(SignupTestDao ajc$this, String name) {
LOGGER.info(ajc$this.testDao);

for (Test test : ajc$this.testDao.findAll()) {
test.setName(name);
ajc$this.testDao.update(test);
if (name.equals("boom"))

{ throw new RuntimeException("boom"); }
}
return "done";
}

Code expected:

static final String updateName_aroundBody0(SignupTestDao ajc$this, String name)
{
LOGGER.info(ajc$this.__gettestDao());

for (Test test : ajc$this.__gettestDao().findAll()) {
test.setName(name);
ajc$this.__gettestDao().update(test);
if (name.equals("boom")) { throw new RuntimeException("boom"); }

}
return "done";
}

A naive fix is to apply iPojo bytecode manipulation to static methods... see the patch provided.