[FELIX-4725] Inner Class Manipulation uses the wrong 'access level'

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: ipojo-manipulator-1.12.0
• Fix Version/s: ipojo-manipulator-1.12.1
• Component/s: iPOJO
• Assignee: Clement Escoffier
• Reporter: Clement Escoffier
• Created: 10/Dec/14 07:29
• Updated: 24/Dec/14 16:23
• Resolved: 10/Dec/14 07:46

Description

When the manipulator manipulates inner classes, the copied method are reusing the same access level than the initial (original method). For instance

public void foo()

is replaced by

public void __foo()

. However, reusing the same access level leads to a (missing) mediation on the invoke instruction we need to use to invoke this method. Despite this is working on traditional JVM (Oracle, HotSpot...), it fails on Dalvik.

The fix is straightforward. Copied methods should be private:

private void __foo()

Thus, we just need to use the

INVOKE_SPECIAL

instruction.