[FELIX-4648] SlingAnnotationProcessor.processSlingFilter cannot deal with multiple scopes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: scr annotations 1.9.8
• Fix Version/s: scr annotations 1.9.10
• Component/s: SCR Tooling
• Assignee: Carsten Ziegeler
• Reporter: Konrad Windszus
• Created: 19/Sep/14 09:43
• Updated: 09/Jan/15 09:56
• Resolved: 21/Sep/14 09:15

Description

If an annotation like this is used:

@SlingFilter(generateComponent = false, generateService = true, order = -700, scope = { SlingFilterScope.REQUEST, SlingFilterScope.ERROR })

the generated XML will contain only the first scope (i.e. request)

....
        <service servicefactory="false">
            <provide interface="javax.servlet.Filter"/>
        </service>
        <property name="service.ranking" type="Integer" value="-700"/>
        <property name="sling.filter.scope" value="REQUEST"/>

The problem is https://github.com/apache/felix/blob/trunk/scrplugin/annotations/src/main/java/org/apache/felix/scrplugin/processing/SlingAnnotationProcessor.java#L191. That can only deal with single values.
Rather it should use the helper method generateStringPropertyDescriptor, like it is done for all the multivalue fields of the annotation @SlingServlet.

Issue Links

• blocks: SLING-3954 i18n filter still not called for error scripts