Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-4647

Incorrect check of the NO_LOCAL_RESOURCES flag in ResolverImpl:resolve()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: bundlerepository-1.6.6
    • Fix Version/s: None
    • Labels:
      None

      Description

      Hello,

      if I understand correctly, the following code is wrong

      ResolverImpl.java:227
      if ((flags & NO_LOCAL_RESOURCES) == 0)
      {
          m_requiredSet.removeAll(Arrays.asList(locals));
      }
      
      ResolverImpl.java:233
      if ((flags & NO_LOCAL_RESOURCES) == 0)
      {
          m_optionalSet.removeAll(Arrays.asList(locals));
      }
      

      I believe, in both cases the conditional should be:

      if ((flags & NO_LOCAL_RESOURCES) != 0)
      

      Due to this bug I'm seeing some important bundles getting auto-uninstalled from ServiceMix container when they are not supposed be. This breaks feature uninstall.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              modax Modestas Vainius
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: