[FELIX-4616] BundleRepository ResourceComparator violates comparison contract

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: bundlerepository-1.6.6
• Fix Version/s: bundlerepository-2.0.4
• Assignee: Carsten Ziegeler
• Reporter: James Scott
• Created: 26/Aug/14 16:23
• Updated: 17/Mar/15 06:51
• Resolved: 27/Aug/14 11:39

Description

The ResourceComparator use to sort resources by presentation name may cause the Arrays.sort to throw IllegalArgumentException if bundles without a bundle name are present.

This occurs because -1 is always returned if two compared resources do not have a bundle name.
This violates the sgn(x,y)=-sgn(y,x) for all x,y.

This forced us into a workaround of setting a system property to force Arrays.sort to use the legacy sort that does not throw exceptions.