[FELIX-4469] shell command "scr help" does not work without parameter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: scr-1.8.2
• Fix Version/s: scr-2.0.0
• Component/s: Declarative Services (SCR)
• Assignee: David Jencks
• Reporter: Vincent G.
• Created: 26/Mar/14 18:22
• Updated: 11/Aug/15 05:09
• Resolved: 27/Apr/14 07:01

Description

Using shell command line with fix of FELIX-4447,

"scr help" returns :
java.lang.NullPointerException
at org.apache.felix.scr.impl.ScrShellCommand.help(ScrShellCommand.java:116)
at org.apache.felix.scr.impl.ScrShellCommand.execute(ScrShellCommand.java:75)
at org.apache.felix.shell.impl.Activator$ShellServiceImpl.executeCommand(Activator.java:249)
at org.apache.felix.shell.remote.Shell.startFelixShell(Shell.java:162)
at org.apache.felix.shell.remote.Shell.run(Shell.java:86)
at java.lang.Thread.run(Thread.java:722)

The code of "void help()" is not expecting "command" to be null.

Intead of :
if (command.equals(LIST_CMD))
you should write :
if (LIST_CMD.equals(command))

Workaround : type anything after "scr help" (example "scr help zzz").