Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-4447

Regression in ScrShellCommand (NPE caused by falsy regex)

    XMLWordPrintableJSON

    Details

      Description

      Using felix console and DS (scr + shell +shell tui), the command scr doesn't work anymore.

      Sample :
      scr list
      -> Unable to execute command: java.lang.NullPointerException
      java.lang.NullPointerException
      at org.apache.felix.scr.impl.ScrShellCommand.help(ScrShellCommand.java:116)
      at org.apache.felix.scr.impl.ScrShellCommand.execute(ScrShellCommand.java:75)
      at org.apache.felix.shell.impl.Activator$ShellServiceImpl.executeCommand(Activator.java:249)
      at org.apache.felix.shell.tui.Activator$ShellTuiRunnable.run(Activator.java:184)
      at java.lang.Thread.run(Unknown Source)

      Looking at source code, in ScrShellCommand.execute(), command is splitted by the falsy regex "//s".
      This should be "
      s+" instead.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                djencks David Jencks
                Reporter:
                olivier.fayau Olivier Fayau
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: