[FELIX-4428] When inserting hosted capability from an already resolved fragment the real non-hosted capability is not removed as a candidate

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: resolver-1.0.0
• Fix Version/s: resolver-1.2.0
• Component/s: Resolver
• Assignee: Richard S. Hall
• Reporter: Tom Watson
• Created: 19/Feb/14 14:34
• Updated: 24/Apr/14 20:55
• Resolved: 24/Apr/14 20:16

Description

In Candidates there are two places where ResolveContext.insertHostedCapability is called:

• org.apache.felix.resolver.Candidates.prepare(ResolveContext)
• org.apache.felix.resolver.Candidates.processCandidates(ResolveContext, Resource, List<Capability>)

In the prepare method the actual fragment capability is correctly removed as a candidate when inserting the hosted capability:

List<Capability> original = ((ShadowList) cands).getOriginal();
int removeIdx = original.indexOf(origCap);
if (removeIdx != -1)

{ original.remove(removeIdx); cands.remove(removeIdx); }

But in the processCandidates method this is not the case. This can lead to invalid Wires being created where the fragment resource is the provider. This happens if the hosted capability introduces a class space inconsistency (from uses constraints). In this case we move on to the next candidate which may be the fragment capability (depending on how the ResolveContext sorts).

The fix is simple, just remove the original fragment capability from the candidate list. I fixed this in equinox with commit:

http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=7efe91f3673e970f32cabc3701e99743a536da00