Felix
  1. Felix
  2. FELIX-4293

[DS] logic error in handling configuration LOCATION_CHANGED event

    Details

      Description

      Pierre de Rop found this with a stack trace like:

      ava.lang.NullPointerException
      at
      org.apache.felix.scr.impl.manager.ComponentFactoryImpl.getProperties(ComponentFactoryImpl.java:226)
      at
      org.apache.felix.scr.impl.manager.ComponentFactoryImpl.configurationUpdated(ComponentFactoryImpl.java:396)
      at
      org.apache.felix.scr.impl.config.ConfigurationSupport.configurationEvent(ConfigurationSupport.java:390)
      at

      The problem occurs because I didn't adapt the code well enough to broken config admin implementations.

        Activity

        Hide
        David Jencks added a comment -

        rev 1535941

        I basically reversed many of the changes in felix-3651 rev 1480108 except now extracting the info we need from the Configuration before ungetting the config admin instance. This makes the logic flow a little clearer.

        Show
        David Jencks added a comment - rev 1535941 I basically reversed many of the changes in felix-3651 rev 1480108 except now extracting the info we need from the Configuration before ungetting the config admin instance. This makes the logic flow a little clearer.
        Hide
        David Jencks added a comment -

        Pierre reports the problem is still there. It looks like CM_LOCATION_CHANGE events are supposed to be sent out even before there are any properties set. In rev 1536005 I added some code to ignore these events.

        Show
        David Jencks added a comment - Pierre reports the problem is still there. It looks like CM_LOCATION_CHANGE events are supposed to be sent out even before there are any properties set. In rev 1536005 I added some code to ignore these events.

          People

          • Assignee:
            David Jencks
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development