Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-4277

The maven-scr-plugin generates false warnings when using @SlingServlet

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • scr annotations 1.9.6
    • scr annotations 1.9.8
    • SCR Tooling
    • None

    Description

      I have a class which is annotated with

      @SlingServlet(resourceTypes = "slingDemo/conferenceSchedule", selectors = "rss", methods = "GET", extensions = "xml")

      In Eclipse and also using the CLI, I get warnings that

      • Property sling.servlet.methods in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)
      • Property sling.servlet.extensions in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)
      • Property sling.servlet.selectors in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)
      • Property sling.servlet.resourceTypes in class de.adaptto.conference_schedule.RssFeedServlet is set as private. This is redundant as no metatype will be generated. (org.apache.felix:maven-scr-plugin:1.15.0:scr:generate-scr-descriptor:process-classes)

      I guess the SlingAnnotationProcessor should not set the propertyPrivate flag if metatype = false, but I'm not sure that this is the correct change.

      Attachments

        1. FELIX-4277-1.patch
          5 kB
          Robert Munteanu

        Activity

          People

            cziegeler Carsten Ziegeler
            rombert Robert Munteanu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: