[FELIX-3590] Add system property resolution to CommandSessionImpl

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: gogo.runtime-0.10.0
• Fix Version/s: gogo.runtime-0.12.0
• Component/s: Gogo Runtime
• Assignee: Unassigned
• Reporter: Christian Schneider
• Created: 11/Jul/12 08:48
• Updated: 12/Jul/12 22:20
• Resolved: 12/Jul/12 21:28

Description

Currently we wrap the CommandProcessor and CommandShell in karaf to simply add the resolution of system properties.

See org.apache.karaf.shell.console.impl.jline.Activator in the karaf console module.

In the innermost code it is only the following we override in CommandSessionImpl.
public Object get(String name) {
Object val = super.get(name);
if (val == null)

{ val = System.getProperty(name); }

return val;
}

So I propose to add this system property resolution to gogo. This would allow us to remove all the wrapping code in karaf.

If you are interested I can provide a patch.