Felix
  1. Felix
  2. FELIX-3466

Pojoization.directoryManipulation() does not take MANIFEST file location into account.

    Details

      Description

      Pojoization.directoryManipulation(File dir,File metadata,File manifest) method does not use the given manifest file location while saving it. Instead it uses a hard-coded $

      {project.output}

      /target/classes/META-INF/MANIFEST.MF path.

      It should be modified to write back its changes to the given file when given file is not null.

        Activity

        Hide
        Göktürk Gezer added a comment -

        Sure,

        I added the test.

        Show
        Göktürk Gezer added a comment - Sure, I added the test.
        Hide
        Clement Escoffier added a comment -

        Could you add a unit test, just to avoid I mess up everything later ?

        Show
        Clement Escoffier added a comment - Could you add a unit test, just to avoid I mess up everything later ?
        Hide
        Göktürk Gezer added a comment -

        A simple fix to also keep file location in DirectoryResourceStore and use it while updating MANIFEST.

        If not supplied, then default path will be assigned by directoryPojoization()

        Show
        Göktürk Gezer added a comment - A simple fix to also keep file location in DirectoryResourceStore and use it while updating MANIFEST. If not supplied, then default path will be assigned by directoryPojoization()

          People

          • Assignee:
            Unassigned
            Reporter:
            Göktürk Gezer
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development