[FELIX-3426] UPnP Plugin device tracking is error-prone

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: webconsole-upnp-plugin-1.0.0
• Fix Version/s: webconsole-upnp-plugin-1.0.2
• Component/s: Web Console
• Assignee: Valentin Valchev
• Reporter: Valentin Valchev
• Created: 03/Apr/12 15:50
• Updated: 03/Apr/12 15:56
• Resolved: 03/Apr/12 15:56

Description

Sometimes, when one device appears, and another is removed, the plugin is unregistered. The reason is that the addingService() and removedService() in the activator are not synchronized.

In addition, in removedService() the code fragment is absolutely incorrect:
if (tracker.getTrackingCount() == 0 && plugin != null)

{ plugin.unregister(); this.plugin = null; }

The reason is that 'tracking count' is always incremented - no matter if a service is registered, modified or unregistered. It is NOT the count of tracked services.