Felix
  1. Felix
  2. FELIX-3396

Fileinstall is not able to handle configuration file if in a path containing braces

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: fileinstall-3.1.10
    • Fix Version/s: fileinstall-3.2.0
    • Component/s: File Install
    • Labels:
      None

      Description

      If fileinstall scans a directory with a path containing braces, the configuration file update fails.

      This is due to the filter in the ConfigInstaller which doesn't escape the braces in the filter:

      (felix.fileinstall.filename=/path/to/(test)/config...)

      should be (with the escape):

      (felix.fileinstall.filename=/path/to/(test)/config...)

      Path with braces are a "classic" installation path especially on Windows (for instance c:
      Program Files(x64)..).

      1. FELIX-3396.patch
        1.0 kB
        Jean-Baptiste Onofré

        Issue Links

          Activity

          Hide
          Forrest Xia added a comment -

          Oops, just saw 3.2.0 release already there

          Show
          Forrest Xia added a comment - Oops, just saw 3.2.0 release already there
          Hide
          Forrest Xia added a comment -

          Hope we could get a fix release soon, thank you in advance!

          Show
          Forrest Xia added a comment - Hope we could get a fix release soon, thank you in advance!
          Hide
          Guillaume Nodet added a comment -

          You're right, I'll apply your patch which is more complete.

          Show
          Guillaume Nodet added a comment - You're right, I'll apply your patch which is more complete.
          Hide
          Forrest Xia added a comment -

          How about '*' and '=' in the path? According to the spec, they both need to escape, right? See 3383 for a complete patch.

          Show
          Forrest Xia added a comment - How about '*' and '=' in the path? According to the spec, they both need to escape, right? See 3383 for a complete patch.

            People

            • Assignee:
              Guillaume Nodet
              Reporter:
              Jean-Baptiste Onofré
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development