[FELIX-3175] RankingComparator results in wrong results

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: configadmin-1.2.8
• Fix Version/s: configadmin-1.4.0
• Component/s: Configuration Admin
• Assignee: Felix Meschberger
• Reporter: Felix Meschberger
• Created: 20/Oct/11 10:28
• Updated: 25/Sep/13 14:02
• Resolved: 20/Oct/11 12:16

Description

The RankingComparator class is used for two cases: ordering ConfigurationPlugin services as per the service.cmRanking property and ordering services as per the service.ranking property. These orderings are slightly different for which the class does not provide properly:

• service.cmRanking sorts ascending and does not define an order amongst services with the same cmRanking value
• service.ranking sorts in descending property value order and defines to fall back to service.id ordering (ascending) in case of equal service.ranking values.

The RankingComparator should be fixed (and simplified) to cope with these two mechanisms.

This should also be tested using unit tests.