Felix
  1. Felix
  2. FELIX-2763

[FileInstall] disableConfigSave actually enables configuration save

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: fileinstall-3.2.0
    • Component/s: File Install
    • Labels:
      None

      Description

      Following FELIX-2699 a configuration option called
      felix.fileinstall.disableConfigSave
      has been introduces to prevent fileinstall to write back configuration changes in the original file.

      However the implementation skip this write-back if the value of the parameter is FALSE. Logically, it should be TRUE.

      Fix is pretty easy ConfigInstaller.java:109, I'm just not sure whether to introduce it or not, since it'll likely break all the applications using this feature.

      I documented anyway the current behaviour in the wiki a https://cwiki.apache.org/confluence/display/FELIX/Apache+Felix+File+Install

        Activity

        Filippo Diotalevi created issue -
        Hide
        Arik Kfir added a comment -

        I'm usually rooting to change incorrect behavior, but to keep backward compabilitiy, I think this property should be deprecated and a new one should be introduced which enforces the correct behavior (overriding this property if both are specified).

        Show
        Arik Kfir added a comment - I'm usually rooting to change incorrect behavior, but to keep backward compabilitiy, I think this property should be deprecated and a new one should be introduced which enforces the correct behavior (overriding this property if both are specified).
        Guillaume Nodet made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Guillaume Nodet [ gnt ]
        Fix Version/s fileinstall-3.1.12 [ 12316135 ]
        Resolution Fixed [ 1 ]
        gnodet committed 1301564 (1 file)

          People

          • Assignee:
            Guillaume Nodet
            Reporter:
            Filippo Diotalevi
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development