[FELIX-2763] [FileInstall] disableConfigSave actually enables configuration save

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: fileinstall-3.2.0
• Component/s: File Install
• Assignee: Guillaume Nodet
• Reporter: Filippo Diotalevi
• Created: 04/Jan/11 21:35
• Updated: 17/Mar/15 07:00
• Resolved: 16/Mar/12 09:23

Description

Following FELIX-2699 a configuration option called
felix.fileinstall.disableConfigSave
has been introduces to prevent fileinstall to write back configuration changes in the original file.

However the implementation skip this write-back if the value of the parameter is FALSE. Logically, it should be TRUE.

Fix is pretty easy ConfigInstaller.java:109, I'm just not sure whether to introduce it or not, since it'll likely break all the applications using this feature.

I documented anyway the current behaviour in the wiki a https://cwiki.apache.org/confluence/display/FELIX/Apache+Felix+File+Install