Felix
  1. Felix
  2. FELIX-2686

iPOJO external handlers should have consistent namespaces

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: iPOJO-1.6.0
    • Fix Version/s: None
    • Component/s: iPOJO
    • Labels:
      None

      Description

      The iPOJO external handlers have different namespaces, and it's confusing. These namespaces must be changed in order to have a coherent naming convention. Nevertheless, backward compatibility must be kept, so existing components can still be used with new versions of handlers

        Activity

        Hide
        Pierre Bourret added a comment -

        Patch for the extender pattern handler.

        Show
        Pierre Bourret added a comment - Patch for the extender pattern handler.
        Hide
        Pierre Bourret added a comment -

        Here is the patch for the eventadmin handler...

        The new namespace no longer uses the deprecated 'Publisher' annotation and XML element (changed to 'Publishes', see FELIX-2621)

        Show
        Pierre Bourret added a comment - Here is the patch for the eventadmin handler... The new namespace no longer uses the deprecated 'Publisher' annotation and XML element (changed to 'Publishes', see FELIX-2621 )
        Hide
        Pierre Bourret added a comment -

        There is a bug in the patch for the JMX handler : the old syntax is not accepted any more by the handler.
        I have corrected this bug and added a test case to check the old syntax compatibility.

        This new patch fixes the problem.

        I'm naughty... All apologies !

        Show
        Pierre Bourret added a comment - There is a bug in the patch for the JMX handler : the old syntax is not accepted any more by the handler. I have corrected this bug and added a test case to check the old syntax compatibility. This new patch fixes the problem. I'm naughty... All apologies !
        Hide
        Pierre Bourret added a comment -

        Here is the patch for the JMX handler ! (very little refactoring of the code also)

        Be careful that some annotations have been moved. Here is the trace of the changes :

        D annotations/src/main/java/org/apache/felix/ipojo/handlers/jmx/JMXMethod.java
        D annotations/src/main/java/org/apache/felix/ipojo/handlers/jmx/JMXProperty.java
        D annotations/src/main/java/org/apache/felix/ipojo/handlers/jmx/JMXBean.java
        A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx
        A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx/JMXMethod.java
        A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx/JMXProperty.java
        A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx/JMXBean.java
        M annotations/pom.xml
        M tests/handler/jmx/src/main/java/org/apache/felix/ipojo/test/component/SimpleManagedComponentAnnotated.java
        M tests/handler/jmx/src/main/java/org/apache/felix/ipojo/test/MBeanTests.java
        M tests/handler/jmx/src/main/resources/metadata.xml
        M handler/jmx/metadata.xml
        M handler/jmx/src/main/java/org/apache/felix/ipojo/handlers/jmx/MBeanHandler.java

        Show
        Pierre Bourret added a comment - Here is the patch for the JMX handler ! (very little refactoring of the code also) Be careful that some annotations have been moved. Here is the trace of the changes : D annotations/src/main/java/org/apache/felix/ipojo/handlers/jmx/JMXMethod.java D annotations/src/main/java/org/apache/felix/ipojo/handlers/jmx/JMXProperty.java D annotations/src/main/java/org/apache/felix/ipojo/handlers/jmx/JMXBean.java A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx/JMXMethod.java A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx/JMXProperty.java A annotations/src/main/java/org/apache/felix/ipojo/handler/jmx/JMXBean.java M annotations/pom.xml M tests/handler/jmx/src/main/java/org/apache/felix/ipojo/test/component/SimpleManagedComponentAnnotated.java M tests/handler/jmx/src/main/java/org/apache/felix/ipojo/test/MBeanTests.java M tests/handler/jmx/src/main/resources/metadata.xml M handler/jmx/metadata.xml M handler/jmx/src/main/java/org/apache/felix/ipojo/handlers/jmx/MBeanHandler.java
        Hide
        Clement Escoffier added a comment -

        Make a lot of sense. Do you have a patch to propose ?

        Show
        Clement Escoffier added a comment - Make a lot of sense. Do you have a patch to propose ?
        Hide
        Pierre Bourret added a comment -

        Here is a list of the current handlers namespaces :

        (NOW)

        • org.apache.felix.ipojo.whiteboard (iPOJO Whiteboard pattern handler 1.4.0)
        • org.apache.felix.ipojo.extender (iPOJO Extender pattern handler 1.4.0 )
        • org.apache.felix.ipojo.handlers.jmx (iPOJO JMX handler 1.4.0)
        • org.apache.felix.ipojo.handlers.event (iPOJO Event Admin handler 1.6.0)
        • org.apache.felix.ipojo.handler.temporal (iPOJO Temporal Dependency handler 1.6.0)

        The idea is to use the same namespace prefix for these handlers : "org.apache.felix.ipojo.handler." .

        (PROPOSITION)

        • org.apache.felix.ipojo.handler.whiteboard
        • org.apache.felix.ipojo.handler.extender
        • org.apache.felix.ipojo.handler.jmx
        • org.apache.felix.ipojo.handler.event
        • org.apache.felix.ipojo.handler.temporal
        Show
        Pierre Bourret added a comment - Here is a list of the current handlers namespaces : (NOW) org.apache.felix.ipojo.whiteboard (iPOJO Whiteboard pattern handler 1.4.0) org.apache.felix.ipojo.extender (iPOJO Extender pattern handler 1.4.0 ) org.apache.felix.ipojo.handlers.jmx (iPOJO JMX handler 1.4.0) org.apache.felix.ipojo.handlers.event (iPOJO Event Admin handler 1.6.0) org.apache.felix.ipojo.handler.temporal (iPOJO Temporal Dependency handler 1.6.0) The idea is to use the same namespace prefix for these handlers : "org.apache.felix.ipojo.handler." . (PROPOSITION) org.apache.felix.ipojo.handler.whiteboard org.apache.felix.ipojo.handler.extender org.apache.felix.ipojo.handler.jmx org.apache.felix.ipojo.handler.event org.apache.felix.ipojo.handler.temporal

          People

          • Assignee:
            Unassigned
            Reporter:
            Pierre Bourret
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development