Felix
  1. Felix
  2. FELIX-2292

Uprage to jetty 7.0 (org.eclipse.jetty 7.0.2v20100331)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: http-2.2.1
    • Component/s: HTTP Service
    • Labels:
      None

      Description

      Hi,

      This is a small improvement of the Http Service in order to use jetty 7.0.2 (org.eclipse.jetty 7.0.2v20100331).
      The patch is following.

      Regards,

      Jonathan

      1. upgrade-jetty7-latest-patch.patch
        14 kB
        Xander Uiterlinden
      2. jetty7GoodFormat.patch
        6 kB
        Jonathan Bardin
      3. jetty7.patch
        18 kB
        Jonathan Bardin

        Activity

        Hide
        Jonathan Bardin added a comment -

        The patch.

        Show
        Jonathan Bardin added a comment - The patch.
        Hide
        Felix Meschberger added a comment -

        Thanks for providing the patch.

        I would like to know whether there are things to consider when migrating from Jetty 6 to Jetty 7 in terms of system requirements, Java requirements, changes in behaviour ... Thanks.

        Could you please fix the formatting of your patch (we place opening brackets { on the next line not on the same line; the ASF license header has been reformatted; we don't have tabs in the pom.xml). Thanks alot !

        Show
        Felix Meschberger added a comment - Thanks for providing the patch. I would like to know whether there are things to consider when migrating from Jetty 6 to Jetty 7 in terms of system requirements, Java requirements, changes in behaviour ... Thanks. Could you please fix the formatting of your patch (we place opening brackets { on the next line not on the same line; the ASF license header has been reformatted; we don't have tabs in the pom.xml). Thanks alot !
        Hide
        Jonathan Bardin added a comment -

        The patch is now in the good format, sorry for this.
        The migration from Jetty 6 to Jetty 7 was pretty straightforward, there is no changes in the behavior. It has been tested with java 6 and 5.

        Thank you,

        Jonathan

        Show
        Jonathan Bardin added a comment - The patch is now in the good format, sorry for this. The migration from Jetty 6 to Jetty 7 was pretty straightforward, there is no changes in the behavior. It has been tested with java 6 and 5. Thank you, Jonathan
        Hide
        Sten Roger Sandvik added a comment -

        Thanks for the patch. Should this patch be applied to a major (2.1.0) or minor (2.0.6) version of the service? What do you guys think?

        Show
        Sten Roger Sandvik added a comment - Thanks for the patch. Should this patch be applied to a major (2.1.0) or minor (2.0.6) version of the service? What do you guys think?
        Hide
        Rob Walker added a comment -

        Personally, I'd say it was a significant change and hence major seems more appropriate

        Show
        Rob Walker added a comment - Personally, I'd say it was a significant change and hence major seems more appropriate
        Hide
        Felix Meschberger added a comment -

        I agree, that this is a major change, thus a new minor number (thus 2.1) (2.0.6 would be a micro or patch number increase).

        Show
        Felix Meschberger added a comment - I agree, that this is a major change, thus a new minor number (thus 2.1) (2.0.6 would be a micro or patch number increase).
        Hide
        Clement Escoffier added a comment -

        It's a major change for me too. So, I would prefer doing a 2.1 release for this change.

        Show
        Clement Escoffier added a comment - It's a major change for me too. So, I would prefer doing a 2.1 release for this change.
        Hide
        Rob Walker added a comment -

        I'm working in this area at present, so if everyone is happy we go for this I'm happy to apply Jonathan's patch and also update the POM version to 2.1-SNAPSHOT (or should that be 2.1.0-SNAPSHOT?)

        Show
        Rob Walker added a comment - I'm working in this area at present, so if everyone is happy we go for this I'm happy to apply Jonathan's patch and also update the POM version to 2.1-SNAPSHOT (or should that be 2.1.0-SNAPSHOT?)
        Hide
        Rob Walker added a comment -

        Thinking about this some more - I wonder if there is anyone who would prefer a later Jetty6 release prior to the Jetty7 one?

        If so, we could do a stepwise upgrade from 6.1.21 to the latest Jetty6 (6.1.24) under say 2.0.6-SNAPSHOT prior to committing the jetty 7 changes under a 2.1.0-SNAPSHOT.

        Obviously this is something of a half-solution - since we're still making an actual cutover point using this approach, albeit at the "current latest Jetty6" version. If anyone had longer term interests in staying on Jetty6, we'd need to figure a way to have parallel options e.g. move the current code to a jetty6 package for those wanting that version.

        I doubt it's much of an issue - just something to consider

        Show
        Rob Walker added a comment - Thinking about this some more - I wonder if there is anyone who would prefer a later Jetty6 release prior to the Jetty7 one? If so, we could do a stepwise upgrade from 6.1.21 to the latest Jetty6 (6.1.24) under say 2.0.6-SNAPSHOT prior to committing the jetty 7 changes under a 2.1.0-SNAPSHOT. Obviously this is something of a half-solution - since we're still making an actual cutover point using this approach, albeit at the "current latest Jetty6" version. If anyone had longer term interests in staying on Jetty6, we'd need to figure a way to have parallel options e.g. move the current code to a jetty6 package for those wanting that version. I doubt it's much of an issue - just something to consider
        Hide
        Rob Walker added a comment -

        Ok - both the new (jetty) and old (http.jetty) implementations seem to work fine on 6.1.24, so as an interim step prior to moving to jetty 7 I'll commit those changes.

        I guess the question then is do we release the current snapshot (2.0.5) prior to starting the 2.1 version on jetty 7. My view would be yes, so that we have a released "final" jetty 6 version on the latest current jetty6 for anyone who doesn't want to go to jetty 7 yet.

        Show
        Rob Walker added a comment - Ok - both the new (jetty) and old (http.jetty) implementations seem to work fine on 6.1.24, so as an interim step prior to moving to jetty 7 I'll commit those changes. I guess the question then is do we release the current snapshot (2.0.5) prior to starting the 2.1 version on jetty 7. My view would be yes, so that we have a released "final" jetty 6 version on the latest current jetty6 for anyone who doesn't want to go to jetty 7 yet.
        Hide
        Xander Uiterlinden added a comment -

        The latest comment on this issue is quite some time ago. For our project we actually need Jetty 7 and would like to use felix.http. Is it still intended to include Jetty 7 in felix.http ?

        Show
        Xander Uiterlinden added a comment - The latest comment on this issue is quite some time ago. For our project we actually need Jetty 7 and would like to use felix.http. Is it still intended to include Jetty 7 in felix.http ?
        Hide
        Felix Meschberger added a comment -

        Yes, but lack of time, you know

        You might give it a try..

        Show
        Felix Meschberger added a comment - Yes, but lack of time, you know You might give it a try..
        Hide
        Xander Uiterlinden added a comment -

        Find enclosed a patch to upgrade the jetty server to 7.6.1.v20120215.

        Show
        Xander Uiterlinden added a comment - Find enclosed a patch to upgrade the jetty server to 7.6.1.v20120215.
        Hide
        Xander Uiterlinden added a comment -

        Committed the changes. Jetty is upgraded to 7.6.3.

        Show
        Xander Uiterlinden added a comment - Committed the changes. Jetty is upgraded to 7.6.3.
        Hide
        Felix Meschberger added a comment -

        Done by Xander. Thanks.

        Show
        Felix Meschberger added a comment - Done by Xander. Thanks.

          People

          • Assignee:
            Xander Uiterlinden
            Reporter:
            Jonathan Bardin
          • Votes:
            5 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development