Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: webconsole-upnp-plugin-1.0.0
-
Component/s: Web Console
-
Labels:None
Description
This plugin is similar to the UPnP Test application but developed as a plugin for the Web Console.
It is developed as standalone plugin - e.g. not build-into the Apache Web Console but is separate bundle.
This allows the plugin to dynamically register/unregister itself. This way the plugin is available only when UPnP Service is active.
Unfortunately I'm not quite aware with maven since most of our projects use ANT. Otherwise I was going to create the full maven structure required to build it.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Targetting for an initial release
IP Clearance has passed by lazy consensus so this patch is ready for import.
Valentin, may I ask you to do the honors ? Thanks.
Vote passed; Software grant has been registered; the IP Clearance page has been updated and the IP Clearance vote has been started [1]
Waiting for IP Clearance vote to pass.
Thanks for resubmitting.
This looks good to me. Two small issues can be fixed on import: I think we can move the note about the original origin to twards the top of the NOTICE file and we may add the ASL header to the bundle*.properties files.
The Licensor in the Software Grant is your Company, i.e. ProSyst Labs. Your CEO (or someone with legal signature competence) will have to sign the grant at the bottom.
Updated the attachment, includes NOTICE and apache headers on top of files.
Refactored the package name and added pom.xml base on the events plugin.
The MD5 sum is:
80390b4b3bed18b16e54ab5492f4b96d upnp.zip
As for the grant - who should be the "Licensor" - me or the CEO of ProSyst Labs?
Thanks for offering this plugin. IMO it fits perfectly in the webconsole-plugins folder of our trunk.
Before proceeding with the next steps outlined below, I would kindly ask you to fix some licensing issues with the attached ZIP file:
- All files must be carrying the standard ASL2 license header.
- The ASL2 LICENSE file should be added
- The NOTICE file should be added. If you wish, you my add a line to the NOTICE file reading something like this:
"Based on source code initially developped by Prosyst" - Provide the MD5 checksum of the attached package as a comment to this issue (to validate the attachement)
The file structure and missing maven pom.xml is not an issue, I can fix this on import.
The next steps involve the following:
- Since this is code, which was developed by you on behalf of Prosyst, we need a Software Grant on file
(This is available from http://www.apache.org/licenses/software-grant.txt; your CLA is already on file, which is perfect) - Once the above listed issues have been fixed, I will start a vote on dev@ to accept this donation
- After the successful vote, the IP process will start (for more people to review adherence to legal requirements)
- Finally, I will then import the contribution.
Committed the source in webconsole-plugins/upnp.