[FELIX-1867] ModuleImpl diagnoseClassLoadError throw NullPointerException for empty package name in debug mode

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: framework-2.0.2
• Fix Version/s: framework-2.0.3
• Component/s: Framework
• Environment: java 1.5/1.6
• Assignee: Richard S. Hall
• Reporter: Guo Du
• Created: 14/Nov/09 13:30
• Updated: 08/Feb/10 21:55
• Resolved: 01/Dec/09 21:46

Description

THE PROBLEM
org.apache.felix.framework.ModuleImpl$ModuleClassLoader throw
NullPointerException when try to load class with default package name
(empty package name) in debug mode (felix.log.level=4).
Felix framework version 2.0.0 (2.0.2 have the same problem)

BACKGROUND
I installed groovy 1.6.5 official release to felix framework, when
evaluate my script, it throw the NullPointerException because groovy
try to dynamically load java.util.Calendar. During the scan, it will
try to load class "java$util$Calendar". The wired format will be
treated by felix class loader as a class with an empty package name.
Following are the stack trace.
Caused by: java.lang.NullPointerException
at org.apache.felix.framework.FelixResolverState.getResolvedCandidates(FelixResolverState.java:652)
at org.apache.felix.framework.Felix$FelixResolver.getResolvedCandidates(Felix.java:3993)
at org.apache.felix.framework.ModuleImpl.diagnoseClassLoadError(ModuleImpl.java:2144)
at org.apache.felix.framework.ModuleImpl.access$400(ModuleImpl.java:60)
at org.apache.felix.framework.ModuleImpl$ModuleClassLoader.loadClass(ModuleImpl.java:1644)
at java.lang.ClassLoader.loadClass(ClassLoader.java:300)
at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:660)

EXCEPTION POINT
org.apache.felix.framework.ModuleImpl
line:2136 try
line:2137

{ line:2138 pkgReq = new Requirement(ICapability.PACKAGE_NAMESPACE, "(package=" + pkgName + ")"); line:2139 }

line:2140 catch (InvalidSyntaxException ex)
line:2141

{ line:2142 // This should never happen. line:2143 }

line:2144 PackageSource[] exporters =
line:2145 resolver.getResolvedCandidates(pkgReq);

We need handle the exception at line:2142 or do something different
before line 2138.