Felix
  1. Felix
  2. FELIX-1058

[PATCH] Add a "find" command to the shell

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: shell-1.2.0
    • Fix Version/s: shell-1.4.0
    • Component/s: Shell
    • Labels:
      None

      Description

      It's not possible to find a bundle easily in the shell. That's very annoying when you are working with 100+ bundles and want to find quickly the id of a specific bundle.
      Other shells, like the Knopflerfish one, offer a "find" command.

      1. FELIX-1058.txt
        11 kB
        Filippo Diotalevi

        Activity

        Hide
        Richard S. Hall added a comment -

        I applied the patch. I saw no issues with it. Please close if you are satisfied. Thanks.

        Show
        Richard S. Hall added a comment - I applied the patch. I saw no issues with it. Please close if you are satisfied. Thanks.
        Hide
        Filippo Diotalevi added a comment -

        The attached patch define a "find" command. This command takes exactly one argument ( "find mybundle" ) and displays a list of bundles whose Bundle-Names or Bundle-Symbolic-Names contain the specified argument. The comparison is case INsensitive.

        Implementation details


        1) Refactored PsCommandImpl to re-use its logic in the new command class
        ---- changed from "private BundleContext m_context" to "protected BundleContext m_context"
        ---- extracted method to display a list of bundles
        2) Added a new FindCommandImpl class
        3) registerd the new command class in the Activator

        Show
        Filippo Diotalevi added a comment - The attached patch define a "find" command. This command takes exactly one argument ( "find mybundle" ) and displays a list of bundles whose Bundle-Names or Bundle-Symbolic-Names contain the specified argument. The comparison is case INsensitive. Implementation details 1) Refactored PsCommandImpl to re-use its logic in the new command class ---- changed from "private BundleContext m_context" to "protected BundleContext m_context" ---- extracted method to display a list of bundles 2) Added a new FindCommandImpl class 3) registerd the new command class in the Activator

          People

          • Assignee:
            Richard S. Hall
            Reporter:
            Filippo Diotalevi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development