[FC-38] Potential issues on synchronized protected elements

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0-RC39
• Fix Version/s: 1.0.0-RC42
• Assignee: Unassigned
• Reporter: Emmanuel Lécharny
• Created: 01/Nov/14 07:04
• Updated: 09/Mar/16 22:15
• Resolved: 09/Mar/16 22:15

Description

There are some classes where we protect a field with a synchronized in order to avoid concurrent modifications. That's ok, except that one should not access the field while it's being updated. There are a few cases where it's done, and this should be fixed.

The way to do it is to use ReentrantReadWriteLock for that : it allows concurrent reads, unless a write lock is taken. Writes will block other writes and all the reads until it's done.

The OrgUnitP and PolicyP are protecting sets while updating it that aren't protected when read (this is fixed for OrgUnitP)

The AdminRoleUtil, HierUtil, PsoUtil, UsoUtil are all manipulating a graph object which is synchronized on update, but not on read. This is probably more complex to fix than for the OrgUnitP/PolicyP classes.

Issue Links

• blocks: FC-151 Possible deadlock condition in roleutil