[FALCON-2272] Extension update succeeds while it is disabled

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: trunk
• Fix Version/s: trunk, 0.11
• Component/s: extensions
• Assignee: sandeep samudrala
• Reporter: Pragya Mittal
• Created: 31/Jan/17 08:52
• Updated: 08/Jun/17 12:18
• Resolved: 01/Feb/17 09:34

Description

pragya.mittal@falcon1001:~$ falcon extension -disable -extensionName extension-example
Status of extension: extension-examplechanged to disabled state state.

pragya.mittal@falcon1001:~$ fepdef sample3-ProcessRecipe-test
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<process name="sample3-ProcessRecipe-test" version="0" xmlns="uri:falcon:process:0.1">
    <tags>_falcon_extension_name=extension-example,_falcon_extension_job=sample3</tags>
    <pipelines>testSample1</pipelines>
    <clusters>
        <cluster name="local" version="0">
            <validity start="2017-01-31T06:00Z" end="2017-01-31T12:00Z"/>
        </cluster>
    </clusters>
    <parallel>1</parallel>
    <order>FIFO</order>
    <frequency>minutes(3)</frequency>
    <timezone>UTC</timezone>
    <inputs>
        <input name="inputData" feed="sample3-input-feed" start="now(0,0)" end="now(0,0)"/>
    </inputs>
    <outputs>
        <output name="outputData" feed="sample3-output-feed" instance="now(0,5)"/>
    </outputs>
    <properties>
        <property name="queueName" value="default"/>
        <property name="fileTime" value="${formatTime(dateOffset(instanceTime(), 1, 'DAY'), 'yyyy-MMM-dd')}"/>
        <property name="user" value="${user()}"/>
    </properties>
    <workflow path="/tmp/falcon-regression/ExtensionTest/aggregator"/>
    <retry policy="periodic" delay="minutes(3)" attempts="3"/>
    <ACL owner="dataqa" group="dataqa" permission="*"/>
</process>

Updating the extension to change process frequency from minutes(3) to minutes(5) should fail as extension is disabled. But it succeeds.

pragya.mittal@falcon1001:~$ falcon extension -update -extensionName extension-example -jobName sample3 -file abc
Updated successfully

New process definition is :

pragya.mittal@falcon1001:~$ fepdef sample3-ProcessRecipe-test
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<process name="sample3-ProcessRecipe-test" version="0" xmlns="uri:falcon:process:0.1">
    <tags>_falcon_extension_name=extension-example,_falcon_extension_job=sample3</tags>
    <pipelines>testSample1</pipelines>
    <clusters>
        <cluster name="local" version="0">
            <validity start="2017-01-31T06:00Z" end="2017-01-31T12:00Z"/>
        </cluster>
    </clusters>
    <parallel>1</parallel>
    <order>FIFO</order>
    <frequency>minutes(5)</frequency>
    <timezone>UTC</timezone>
    <inputs>
        <input name="inputData" feed="sample3-input-feed" start="now(0,0)" end="now(0,0)"/>
    </inputs>
    <outputs>
        <output name="outputData" feed="sample3-output-feed" instance="now(0,5)"/>
    </outputs>
    <properties>
        <property name="queueName" value="default"/>
        <property name="fileTime" value="${formatTime(dateOffset(instanceTime(), 1, 'DAY'), 'yyyy-MMM-dd')}"/>
        <property name="user" value="${user()}"/>
    </properties>
    <workflow path="/tmp/falcon-regression/ExtensionTest/aggregator"/>
    <retry policy="periodic" delay="minutes(3)" attempts="3"/>
    <ACL owner="dataqa" group="dataqa" permission="*"/>
</process>

Issue Links

• blocks: FALCON-2182 Add support for Falcon user extensions
• links to: GitHub Pull Request #351