[FALCON-1735] FalconException shouldn't be caught in AbstractRerunHandler in case of obtaining Workflow engine from entity

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9
• Assignee: pavan kumar kolamuri
• Reporter: pavan kumar kolamuri
• Created: 07/Jan/16 07:06
• Updated: 11/Jan/16 12:41
• Resolved: 11/Jan/16 12:41

Description

WorkflowEngineFactory.getWorkflowEngine(Entity entity) throw FalconException in three cases
1) When it didnt find org.apache.falcon.workflow.engine.FalconWorkflowEngine this class in class path
2) When StateStore is not initialized
3) FalconException will be thrown if entity is not present in configStore.

I thought when org.apache.falcon.workflow.engine.FalconWorkflowEngine doesn't exists its better to return defaultworkflowengine but looks like it might not occur since FalconWorkflowEngine will be present always from now .
Second case is not possible it won't throw FalconException it might throw other runtime exceptions
Third case won't occur generally but still we shouldn't catch exception and return Default WorkflowEngine.